Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect submodules not synced #556

Conversation

@ssteinbach
Copy link
Member

commented Aug 7, 2019

Add code in the CMake build system to automatically run git submodule update.

Addresses #553

ssteinbach added some commits Aug 7, 2019

Add check to see if submodules have been synced
Because we're now using git submodules to track dependencies, its
possible to get into a state where the submodules need to be updated or
synced.
Move git submodule code to CMake build system
Rather than put the submodule detection in the setup.py, put it into the
CMake build system since the core of the library is considered to be
C++.

@ssteinbach ssteinbach added this to the Public Beta 12 milestone Aug 7, 2019

@ssteinbach ssteinbach added this to To Do in C++ API via automation Aug 7, 2019

@swallitsch
Copy link
Contributor

left a comment

If git is not found, we might want to check if those git repos are empty and print a more direct warning.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 7, 2019

Codecov Report

Merging #556 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #556   +/-   ##
=======================================
  Coverage   81.28%   81.28%           
=======================================
  Files          72       72           
  Lines        2731     2731           
=======================================
  Hits         2220     2220           
  Misses        511      511
Flag Coverage Δ
#py27 81.29% <ø> (ø) ⬆️
#py36 81.29% <ø> (ø) ⬆️
#py37 81.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99b388...00aee38. Read the comment docs.

@ssteinbach

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

@swallitsch great note! I added an extra check in the CMakeLists.txt in the src/deps folder that explicitly checks the submodules to make sure they exist with a more exact message of what might be going on.

@ssteinbach ssteinbach requested a review from mikemahony Aug 7, 2019

@ssteinbach ssteinbach merged commit faa5827 into PixarAnimationStudios:master Aug 8, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

C++ API automation moved this from To Do to Done Aug 8, 2019

@ssteinbach ssteinbach deleted the ssteinbach:detect_submodules_not_synced branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.