Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#551 AAF Adapter creates ExternalReference for UNC Path #560

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@JoshBurnell
Copy link
Contributor

commented Aug 20, 2019

Moved from a closed PR (had trouble with the cxx-to-master rebase). Unittest added. Sorry for any confusion.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 20, 2019

Codecov Report

Merging #560 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   81.28%   81.28%           
=======================================
  Files          72       72           
  Lines        2731     2731           
=======================================
  Hits         2220     2220           
  Misses        511      511
Flag Coverage Δ
#py27 81.29% <ø> (ø) ⬆️
#py36 ?
#py37 81.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36f85f7...1c3a359. Read the comment docs.

@jminor

This comment has been minimized.

Copy link
Collaborator

commented Aug 28, 2019

The python 2.7 CI failure looks like a temporary glitch. I kicked it to see if it goes through the 2nd time.

@jminor
jminor approved these changes Aug 28, 2019

@jminor jminor merged commit 0c9655c into PixarAnimationStudios:master Aug 28, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.