Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract target_url from Essence locator in SourceMob #588

Merged
merged 4 commits into from Oct 3, 2019

Conversation

@JoshBurnell
Copy link
Contributor

commented Sep 25, 2019

From Issue #587 ...

We're attempting to use the AAF Adapter to convert our composition AAF's to OTIO's, however the resulting OTIO doesn't contain references to much of the media. We do get some of it in the MasterMob metadata (#551), but we're not getting any of the media that was contained in SourceMob Essences.

The advanced_authoring_format.py format does manage to get the relevant MasterMob, but it doesn't dissect it.

This may be related to Issue #482 in some way. This also may be related to how we're exportting our AAF's from AVID, so if someone has already worked through this issue, lemme know.

@jminor

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2019

@JoshBurnell here's the existing AAF samples, which all get tested when the unit tests run: https://github.com/PixarAnimationStudios/OpenTimelineIO/tree/master/contrib/opentimelineio_contrib/adapters/tests/sample_data
That's a good place to add a new one to cover this PR.

@JoshBurnell

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

Updated with test AAF and unittest (and adapters/tests/init.py for convenience)

Josh Burnell
@codecov-io

This comment has been minimized.

Copy link

commented Sep 27, 2019

Codecov Report

Merging #588 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #588   +/-   ##
======================================
  Coverage    81.6%   81.6%           
======================================
  Files          72      72           
  Lines        2729    2729           
======================================
  Hits         2227    2227           
  Misses        502     502
Flag Coverage Δ
#py27 81.58% <ø> (ø) ⬆️
#py36 81.58% <ø> (?)
#py37 81.58% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/opentimelineio/serializableObject.cpp 58.82% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c0951...cac3f5a. Read the comment docs.

for clip in video_track:
self.assertIsInstance(clip.media_reference,
otio.schema.ExternalReference)
self.assertIsNotNone(clip.media_reference.target_url)

This comment has been minimized.

Copy link
@jminor

jminor Sep 27, 2019

Collaborator

If you compare the actual contents of target_url then this test will cover the handling of backslashes as well. I have a slight worry that there might be a platform dependency on the path separator in these UNC paths, so it would be good to check that.

This comment has been minimized.

Copy link
@jminor

jminor Sep 30, 2019

Collaborator

@JoshBurnell would you mind adding a check for the correct target_url here?

@jminor jminor added this to To do in AAF Adapter via automation Sep 30, 2019
AAF Adapter automation moved this from To do to In progress Sep 30, 2019
for clip in video_track:
self.assertIsInstance(clip.media_reference,
otio.schema.ExternalReference)
self.assertIsNotNone(clip.media_reference.target_url)

This comment has been minimized.

Copy link
@jminor

jminor Sep 30, 2019

Collaborator

@JoshBurnell would you mind adding a check for the correct target_url here?

Josh Burnell
@jminor
jminor approved these changes Oct 2, 2019
@jminor jminor merged commit 977b65b into PixarAnimationStudios:master Oct 3, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
AAF Adapter automation moved this from In progress to Done Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
AAF Adapter
  
Done
3 participants
You can’t perform that action at this time.