Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak docs on C++ building. #601

Merged
merged 6 commits into from Oct 4, 2019

Conversation

@meshula
Copy link
Collaborator

commented Oct 2, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

commented Oct 2, 2019

Codecov Report

Merging #601 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   81.58%   81.67%   +0.09%     
==========================================
  Files          72       72              
  Lines        2726     2729       +3     
==========================================
+ Hits         2224     2229       +5     
+ Misses        502      500       -2
Flag Coverage Δ
#py27 81.65% <ø> (+0.07%) ⬆️
#py36 81.65% <ø> (?)
#py37 81.65% <ø> (?)
Impacted Files Coverage Δ
...eio/opentimelineio-bindings/otio_anyDictionary.cpp 100% <0%> (ø) ⬆️
...elineio/opentimelineio-bindings/otio_anyVector.cpp 100% <0%> (ø) ⬆️
...ntimelineio/opentimelineio-bindings/otio_utils.cpp 87.2% <0%> (+0.15%) ⬆️
src/opentimelineio/serialization.cpp 82.6% <0%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c89b24d...579d324. Read the comment docs.

@ssteinbach

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

@jminor the idea here is to break the developer quickstart out of the readme and put it into the readthedocs page (with a link in the readme).

Copy link
Member

left a comment

LGTM

docs/tutorials/quickstart.md Outdated Show resolved Hide resolved
Nick Porcino added 2 commits Oct 3, 2019
Nick Porcino
Nick Porcino
Copy link
Member

left a comment

Thanks Nick, this looks good to me.

@ssteinbach ssteinbach merged commit 9e4c203 into PixarAnimationStudios:master Oct 4, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.