Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding support for negative time strings when converting a negative #605
RationalTime object to a string.
Before this change, doing
timeString would be
This change introduces a 'negative' time string, i.e. generate the
timeString is now:
This is actually a valid string format for ffmpeg and useful if you
RationalTime object to a string. Before this change, doing negativeRationalTime = otio.opentime.RationalTime(-24,24) timeString = otio.opentime.to_time_string(negativeRationalTime) timeString would be "-1
👎-10", which is not a useful time string. This change will create a 'negative' time string, i.e. generate the same string value as a positive RationalTime value would do but with a '-' sign in front of the string: timeString is now: '-00:00:01.0' This is actually a valid string format for ffmpeg and useful if you for example want to add silence to an audio file at the beginning.
@@ Coverage Diff @@ ## master #605 +/- ## ========================================== + Coverage 81.67% 81.69% +0.02% ========================================== Files 72 72 Lines 2729 2732 +3 ========================================== + Hits 2229 2232 +3 Misses 500 500