Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD is breaking on StrictVersion in #615



Copy link

@ssteinbach ssteinbach commented Nov 7, 2019

RTD is getting a crazy traceback in from this line:

      File "/tmp/pip-req-build-i6tc3y8j/", line 253, in <module>
      File "/home/docs/checkouts/", line 40, in __init__
      File "/home/docs/checkouts/", line 137, in parse
        raise ValueError("invalid version number '%s'" % vstring)

Doing some googling on StrictVersion vs LooseVersion, it sounds like what we really want is LooseVersion? If python packaging folks know more, please speak up!

Also bumping RTD to use python3.7 instead of 3.6.

@ssteinbach ssteinbach added this to the Public Beta 12 milestone Nov 7, 2019
Copy link

@codecov-io codecov-io commented Nov 7, 2019

Codecov Report

Merging #615 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #615   +/-   ##
  Coverage   81.69%   81.69%           
  Files          72       72           
  Lines        2732     2732           
  Hits         2232     2232           
  Misses        500      500
Flag Coverage Δ
#py27 81.67% <ø> (ø) ⬆️
#py36 81.67% <ø> (ø) ⬆️
#py37 81.67% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8392360...f3ff06e. Read the comment docs.

meshula approved these changes Nov 7, 2019
@meshula meshula merged commit 6d32687 into PixarAnimationStudios:master Nov 7, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants