Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the windows build #669

Merged
merged 2 commits into from Mar 24, 2020
Merged

Fix the windows build #669

merged 2 commits into from Mar 24, 2020

Conversation

@meshula
Copy link
Collaborator

meshula commented Mar 24, 2020

Add a bin target to satisfy cmake windows requirement, bump the version to cmake 3.

The cmake version for Linux is per vfx-platform 2018, the version for Windows is the latest, otherwise VS2019 can't be supported.

@meshula meshula requested a review from ssteinbach Mar 24, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 24, 2020

Codecov Report

Merging #669 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #669   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files          72       72           
  Lines        2731     2731           
=======================================
  Hits         2231     2231           
  Misses        500      500           
Flag Coverage Δ
#py27 81.67% <ø> (ø)
#py36 81.67% <ø> (ø)
#py37 81.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a43d22a...92127f7. Read the comment docs.

README.md Outdated Show resolved Hide resolved
@meshula meshula merged commit 9d010f2 into master Mar 24, 2020
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
ssteinbach added a commit to ssteinbach/OpenTimelineIO that referenced this pull request Mar 26, 2020
* Fix the windows build

* Don't need to specify --recursive when cloning
@ssteinbach ssteinbach added this to the Public Beta 12 milestone Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.