Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flatten_video_tracks.py to use deepcopy. #812

Merged

Conversation

jminor
Copy link
Collaborator

@jminor jminor commented Oct 7, 2020

Link the Issue(s) this Pull Request is related to.

Fixes #811

Summarize your change.

Now the example uses deepcopy when splicing the audio tracks into the output timeline.

Reference associated tests.

There are no tests for the code in the examples/ folder.

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #812 into master will decrease coverage by 6.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
- Coverage   84.02%   77.54%   -6.49%     
==========================================
  Files          74      109      +35     
  Lines        3124     5647    +2523     
==========================================
+ Hits         2625     4379    +1754     
- Misses        499     1268     +769     
Flag Coverage Δ
#py27 ?
#py37 ?
#py38 ?
#unittests 77.54% <ø> (-6.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntimelineio/opentimelineio-bindings/otio_utils.cpp 86.90% <0.00%> (-0.46%) ⬇️
src/opentimelineio/typeRegistry.cpp 84.84% <0.00%> (-0.45%) ⬇️
...entimelineio-bindings/otio_serializableObjects.cpp 95.11% <0.00%> (-0.31%) ⬇️
src/opentimelineio/item.cpp 90.47% <0.00%> (-0.15%) ⬇️
...lineio/opentime-bindings/opentime_rationalTime.cpp 97.36% <0.00%> (-0.07%) ⬇️
src/opentimelineio/serialization.cpp 83.60% <0.00%> (-0.06%) ⬇️
src/opentimelineio/timeline.h 100.00% <0.00%> (ø)
src/opentimelineio/typeRegistry.h 100.00% <0.00%> (ø)
...imelineio/opentime-bindings/opentime_timeRange.cpp 100.00% <0.00%> (ø)
...melineio/opentimelineio-bindings/otio_bindings.cpp 100.00% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8be8eaa...f694407. Read the comment docs.

@jminor
Copy link
Collaborator Author

jminor commented Oct 7, 2020

@ssteinbach do you have any clue about why the code coverage system is confused by this? The file I changed isn't even run by the unit tests, so I don't see how the coverage could drop by any amount, let alone 6.48%

@ssteinbach
Copy link
Collaborator

Thats probably a bug in coverage, which happens sometimes. I'll try kicking the CI and see if the new report is correct?

@ssteinbach ssteinbach merged commit bef0d8d into AcademySoftwareFoundation:master Oct 12, 2020
@ssteinbach ssteinbach added this to the Public Beta 14 milestone Oct 13, 2020
@jminor jminor deleted the fix_flatten_example branch October 14, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants