Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example timeline builder #993

Merged

Conversation

ssteinbach
Copy link
Collaborator

@ssteinbach ssteinbach commented Jun 22, 2021

Adds a simple example that builds a timeline from scratch using a list of files and times as input.

  • add a command line argument to take a path of where to put the resulting file
  • add a more helpful docstring

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2021

Codecov Report

Merging #993 (3f8e914) into master (d33bf24) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #993   +/-   ##
=======================================
  Coverage   85.60%   85.60%           
=======================================
  Files         192      192           
  Lines       18331    18331           
  Branches     2056     2056           
=======================================
  Hits        15693    15693           
  Misses       2112     2112           
  Partials      526      526           
Flag Coverage Δ
unittests 85.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33bf24...3f8e914. Read the comment docs.

@ssteinbach ssteinbach marked this pull request as draft June 22, 2021 03:08
@ssteinbach ssteinbach added this to the Public Beta 14 milestone Jun 22, 2021
@ssteinbach ssteinbach marked this pull request as ready for review June 22, 2021 03:27
Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ssteinbach ssteinbach merged commit 2b11097 into AcademySoftwareFoundation:master Jun 25, 2021
@ssteinbach ssteinbach deleted the example_build_timeline branch June 25, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants