Fix MaterialX Nodedef Discovery #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use getActiveInputs to get all inputs of a NodeDef This API will traverse the inheritance hierarchy to provide the complete list of inputs of a NodeDef.
|
Filed as internal issue #USD-6944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Updated the discovery process to request all NodeDefs directly from the library. This fixes #1629 where implementation were not able to provide their NodeDef, and supports a future where multiple NodeDef could be implemented with the same NodeGraph.
Also fixed issue where the versionless name discovered for ND_standard_surface_surfaceshader was wrong. In this case, the latest version has the versionless name, while the predecessor is version tagged, so the name mapping algorithm was updated to choose the shortest name in the hierarchy.
Updated the parser to also fetch the NodeDef from the library.
Use the correct API to get the complete port interface from the inheritance hierarchy.
Fixes Issue(s)