Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR. #1971

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Replace CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR. #1971

merged 1 commit into from
Jan 27, 2023

Conversation

jdumas
Copy link
Contributor

@jdumas jdumas commented Jul 29, 2022 •
edited by tallytalwar
Loading

Description of Change(s)

In order to allow building USD as a subdirectory with CMake, it is necessary to change all CMAKE_SOURCE_DIR --> PROJECT_SOURCE_DIR, and CMAKE_BINARY_DIR --> PROJECT_BINARY_DIR .

  • I have submitted a signed Contributor License Agreement (corporate CLA via Adobe).

@sunyab
Copy link
Contributor

sunyab commented Aug 1, 2022

Filed as internal issue #USD-7529

@spiffmon
Copy link
Member

Apologies, @jdumas - we don't have you listed on our Adobe corporate CLA; can you please ping @guidoq to email us to add you?

Thanks!

@sunyab sunyab changed the base branch from release to dev January 25, 2023 19:50
@pixar-oss pixar-oss merged commit b76a764 into PixarAnimationStudios:dev Jan 27, 2023
@jdumas jdumas deleted the jdumas/cmake branch January 27, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdumas @sunyab @spiffmon @pixar-oss