Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid using cpp keywords as tokens after camelCased #2020

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

sssooonnnggg
Copy link
Contributor

If we define a token such as "Default", the generated cpp code will not compile.
Because the cpp keyword check is performed before camelCased, so the token "default" is used as a variable name in generated code, which causes compile issues.

@sssooonnnggg sssooonnnggg changed the base branch from release to dev September 2, 2022 07:56
@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-7609

@sssooonnnggg sssooonnnggg reopened this Sep 7, 2022
@pixar-oss pixar-oss merged commit 9045f9a into PixarAnimationStudios:dev Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants