Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPLE: Use unique name for debug View. #2256

Merged

Conversation

creijon
Copy link
Contributor

@creijon creijon commented Feb 8, 2023

Description of Change(s)

Using View as a classname in the code can cause issues when integrating with other Cocoa applications. To avoid this, rename it to Garch_GLView

Fixes Issue(s)

  • Potential name conflicts in Cocoa applications.
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-7990

@creijon creijon force-pushed the jon/dev/rename_debug_view branch 2 times, most recently from b4efedb to d18483c Compare February 24, 2023 18:18
@pixar-oss pixar-oss merged commit 728d3eb into PixarAnimationStudios:dev Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants