New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue loading Libs #2

Open
jessefreeman opened this Issue Dec 31, 2018 · 3 comments

Comments

Projects
None yet
1 participant
@jessefreeman
Copy link
Contributor

jessefreeman commented Dec 31, 2018

Looks like there is an issue when loading libraries from multiple locations. From time to time, it will get a nil error on a library file since the reference lua script was not loaded correctly. This may be a race condition with the threaded loading.

image

Quitting from a screen like Settings or View Log gave semi-consistently gave me a Lua error which made me have to reset PV8 with Ctrl+4.

image

I went to the log screen to see if there was anything about the error there, but the log was empty. Since it looked like you could type in it, I placed the cursor there and typed a letter, which led to this error.

@jessefreeman

This comment has been minimized.

Copy link
Contributor

jessefreeman commented Jan 1, 2019

Removed threading to fix this.

@jessefreeman

This comment has been minimized.

Copy link
Contributor

jessefreeman commented Jan 10, 2019

Looks like this is still happening so it's probably not part of the threading. I need to reimplement threading and look into permission issues between game sessions or cache the core libs so they are always available at an OS level.

@jessefreeman jessefreeman reopened this Jan 10, 2019

@jessefreeman

This comment has been minimized.

Copy link
Contributor

jessefreeman commented Jan 12, 2019

Noticing a path error that is being caught but not outputted to the log in the WorkspaceService when trying to save some tools.

screenshot 2019-01-12 07 09 09

screenshot 2019-01-12 07 14 28

Found this while loading a game in a nested folder in Play with the OS loaded as the main disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment