Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Tool isn't limiting pages based on specs #113

Closed
jessefreeman opened this issue Feb 22, 2019 · 2 comments

Comments

1 participant
@jessefreeman
Copy link
Contributor

commented Feb 22, 2019

The color tool needs to limit the maximum number of colors based on the system specs set in the chip editor and data.json file.

image

Notice how it is showing two pages but in the chip editor, it's only one page.

image

@jessefreeman jessefreeman added the bug label Feb 22, 2019

@jessefreeman jessefreeman self-assigned this Feb 22, 2019

@jessefreeman jessefreeman added this to Needs triage in Color Tool v2 via automation Feb 22, 2019

@jessefreeman

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2019

This has some complicated edge cases. First off, palette memory is part of the color memory so we need to make sure that when we split colors if there are only 1 or 2 pages for system colors, the palettes are not affected by this. Right now the color tool doesn't take this into account so theoretically, the palette colors may not be imported correctly.

In reality, palette mode should split color memory in half, based on the total pages. And half the colors go to system and other to palettes. That means the worst case scenario is that 1 page of color memory would allow for 32 system colors and 2 (16 color palettes).

Right now all of this is hardcoded around the assumption that there are really 256 colors since palettes are not "native" to the color chip.

@jessefreeman jessefreeman moved this from Needs triage to High priority in Color Tool v2 Feb 24, 2019

@jessefreeman jessefreeman added this to the Release v2.3.0 milestone Feb 24, 2019

@jessefreeman

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2019

This has been addressed since pages are no longer part of the Color Chip. The engine will now load the maximum number of colors defined in the data.json file.

Color Tool v2 automation moved this from High priority to Closed Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.