New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wave buttons #29

Closed
jessefreeman opened this Issue Dec 31, 2018 · 1 comment

Comments

1 participant
@jessefreeman
Copy link
Contributor

jessefreeman commented Dec 31, 2018

Need to go in and fix the wav buttons:

image

The first wave is labeled "Triangle" and does sound like a triangle wave, but the waveform that is displayed is a sawtooth

The second wave (square) is correct, but for purists, it may feel a little "off" to call it a square wave rather than a pulse wave (seeing how it has a duty cycle that is user-defined)(edited)

The third wave is labeled "Sawtooth" and does sound like a sawtooth, but the waveform that is displayed on the button is that of a sine wave.

The fourth button is completely correct

@jessefreeman jessefreeman added the bug label Dec 31, 2018

@jessefreeman jessefreeman added this to the v0.9.0 Features milestone Dec 31, 2018

@jessefreeman jessefreeman self-assigned this Dec 31, 2018

@jessefreeman jessefreeman added this to Needs triage in SFX Tool v2 via automation Dec 31, 2018

@jessefreeman jessefreeman moved this from Needs triage to High priority in SFX Tool v2 Jan 1, 2019

@jessefreeman

This comment has been minimized.

Copy link
Contributor

jessefreeman commented Jan 2, 2019

The wave buttons now reflect the correct icons.

SFX Tool v2 automation moved this from High priority to Closed Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment