Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cropping do x,y,w,h instead of l,t,r,b #179

Closed
fluffy-critter opened this issue Mar 4, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@fluffy-critter
Copy link
Collaborator

commented Mar 4, 2019

Expected Behavior

crop and fullsize_crop should use the upper-left corner and width/height of the cropping rectangle.

Current Behavior

It uses the two corners' coordinates, which makes no sense if the corner specified (r,b) is to the left or above the corner specified by (l,t).

Context

x,y,w,h coordinates maks more sense intuitively and matches the vast majority of image processing software. The main reason to go with l,t,r,b is that it maps directly into PILlow, but that isn't a good reason to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.