Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to watermark images by parameter #330

Open
fluffy-critter opened this issue Jan 13, 2020 · 2 comments
Open

Add ability to watermark images by parameter #330

fluffy-critter opened this issue Jan 13, 2020 · 2 comments
Labels
images Stuff to do with image renditions
Milestone

Comments

@fluffy-critter
Copy link
Collaborator

fluffy-critter commented Jan 13, 2020

Expected Behavior

For purposes of protecting images there should be a watermark parameter which lets you add an arbitrary text string to the image as well as the file name and EXIF. This should also propagate as a full screen attribute.

Example: ![{watermark="beesbuzz.biz for "~user.name}](sexypic.jpg)

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

@fluffy-critter fluffy-critter added the images Stuff to do with image renditions label Jan 13, 2020
@fluffy-critter fluffy-critter added this to the 0.7 milestone Mar 7, 2020
@fluffy-critter
Copy link
Collaborator Author

Note that the above Markdown won't work because Markdown doesn't execute in a Jinja context, so the ~ operator and Jinja context variables aren't available. Maybe there should be some additional templating stuff available to the Markdown engine, or something.

@fluffy-critter fluffy-critter modified the milestones: 0.7, 0.8 May 28, 2020
@fluffy-critter
Copy link
Collaborator Author

It's possible that Python f""-strings are available from the Jinja context. Or simply always provide a .format(user=user,request=request,...) to the string so that the invocation could be something like:

![{watermark="beesbuzz.biz for {user.name}"}](image.jpg)

although that in turn might cause some weird parse issues for the Markdown extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
images Stuff to do with image renditions
Projects
None yet
Development

No branches or pull requests

1 participant