Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing in diagnostics/tests/ #494

merged 1 commit into from Jun 11, 2018


None yet
3 participants
Copy link

ritiek commented Jun 11, 2018

As suggested in #489 (comment) we're missing an in plasmapy/diagnostics/tests/ (and tests aren't probably running either). This PR just adds an empty to that directory.


This comment has been minimized.

Copy link

codecov bot commented Jun 11, 2018

Codecov Report

Merging #494 into master will increase coverage by 2.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #494      +/-   ##
+ Coverage   93.18%   95.38%   +2.19%     
  Files          70       71       +1     
  Lines        6871     6953      +82     
+ Hits         6403     6632     +229     
+ Misses        468      321     -147
Impacted Files Coverage Δ
plasmapy/diagnostics/tests/ 98.78% <0%> (ø)
plasmapy/diagnostics/ 66.78% <0%> (+52.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3673ddb...7024f11. Read the comment docs.


This comment has been minimized.

Copy link
Contributor Author

ritiek commented Jun 11, 2018

Woah! The tests weren't running indeed!

I skimmed through other tests directories, looks like they all have, so we should be good to go.


This comment has been minimized.

Copy link

StanczakDominik commented Jun 11, 2018

Whoa! You know, I might have removed those init files earlier, as I thought we wouldn't import stuff from there so they were unnecessary. Pretty crazy! Thanks for figuring this out!

@StanczakDominik StanczakDominik merged commit 9ec848c into PlasmaPy:master Jun 11, 2018

5 checks passed

ci/circleci: test-html Your tests passed on CircleCI!
codecov/patch Coverage not affected when comparing 3673ddb...7024f11
codecov/project 95.38% (+2.19%) compared to 3673ddb
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@ritiek ritiek deleted the ritiek:diagnostics-test-init branch Jun 11, 2018

StanczakDominik added a commit to StanczakDominik/PlasmaPy that referenced this pull request Sep 5, 2018

Merge pull request PlasmaPy#494 from ritiek/diagnostics-test-init
Add missing in diagnostics/tests/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.