Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage in langmuir.py #498

Merged
merged 5 commits into from Jun 14, 2018

Conversation

Projects
None yet
4 participants
@ritiek
Copy link
Contributor

commented Jun 14, 2018

Some functions and lines of code in langmuir.py were untested. So, I've added several more tests to cover up what has been missing.

@pep8speaks

This comment has been minimized.

Copy link

commented Jun 14, 2018

Hello @ritiek! Thanks for updating your pull request.

Congratulations! There are no PEP8 issues in this pull request. 😸

Comment last updated on June 14, 2018 at 18:15 Hours UTC
@codecov

This comment has been minimized.

Copy link

commented Jun 14, 2018

Codecov Report

Merging #498 into master will increase coverage by 0.53%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   95.38%   95.91%   +0.53%     
==========================================
  Files          71       71              
  Lines        6953     7031      +78     
==========================================
+ Hits         6632     6744     +112     
+ Misses        321      287      -34
Impacted Files Coverage Δ
plasmapy/diagnostics/tests/test_langmuir.py 100% <100%> (+1.21%) ⬆️
plasmapy/diagnostics/langmuir.py 78.57% <100%> (+11.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ec848c...a3a4cf7. Read the comment docs.

@StanczakDominik
Copy link
Member

left a comment

Neat! If there's nothing left to add, I'll be happy to merge this one :)

@ritiek

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2018

Yep, should be ready to merge!

@StanczakDominik

This comment has been minimized.

Copy link
Member

commented Jun 14, 2018

Righty-o, then! Thanks for this one!

@StanczakDominik StanczakDominik merged commit 5e8a6be into PlasmaPy:master Jun 14, 2018

5 checks passed

ci/circleci: test-html Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.38%)
Details
codecov/project 95.91% (+0.53%) compared to 9ec848c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ritiek ritiek deleted the ritiek:langmuir-tests branch Jun 14, 2018

StanczakDominik added a commit to StanczakDominik/PlasmaPy that referenced this pull request Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.