Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `roman_symbol` attribute on `Particle` class to return integer charge in Roman notation #504

Merged
merged 3 commits into from Jun 26, 2018

Conversation

Projects
None yet
3 participants
@ritiek
Copy link
Contributor

commented Jun 25, 2018

Supersedes #468.
Closes #464.

Adds a property to the Particle class to return ion symbols in Roman notation. The Roman numeral is the charge of the ion plus one. For example,

>>> from plasmapy.atomic import *
>>> proton = Particle('proton')
>>> proton.roman_symbol
'H II'

Closes #464.

It seems like @Elfhelm hasn't been active on GitHub lately. This PR incorporates minor fixes as suggested in #468.

@codecov

This comment has been minimized.

Copy link

commented Jun 25, 2018

Codecov Report

Merging #504 into master will increase coverage by 1.76%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   95.94%   97.71%   +1.76%     
==========================================
  Files          71       41      -30     
  Lines        7159     3590    -3569     
==========================================
- Hits         6869     3508    -3361     
+ Misses        290       82     -208
Impacted Files Coverage Δ
plasmapy/atomic/particle_class.py 99.67% <100%> (+2.49%) ⬆️
plasmapy/physics/distribution.py 100% <0%> (ø) ⬆️
plasmapy/classes/sources/plasmablob.py 100% <0%> (ø) ⬆️
plasmapy/classes/tests/test_Species.py
plasmapy/atomic/tests/test_parsing.py
plasmapy/atomic/tests/test_special_particles.py
plasmapy/mathematics/tests/__init__.py
plasmapy/classes/tests/test_plasma_factory.py
plasmapy/physics/tests/test_parameters_cython.py
plasmapy/physics/tests/test_dimensionless.py
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b2b3f...c6e3971. Read the comment docs.

@StanczakDominik
Copy link
Member

left a comment

Looks good to me!

@StanczakDominik StanczakDominik merged commit f7310aa into PlasmaPy:master Jun 26, 2018

5 checks passed

ci/circleci: test-html Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.94%)
Details
codecov/project 97.71% (+1.76%) compared to 27bfbed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ritiek ritiek deleted the ritiek:roman-symbols branch Jun 26, 2018

@namurphy namurphy added the Atomic label Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.