Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few more tests to improve our test coverage #506

Merged
merged 5 commits into from Jul 2, 2018

Conversation

Projects
None yet
4 participants
@ritiek
Copy link
Contributor

ritiek commented Jun 30, 2018

This PR just adds some more tests to cover a few lines we've been missing out in our codebase.

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Jun 30, 2018

Hello @ritiek! Thanks for updating your pull request.

Congratulations! There are no PEP8 issues in this pull request. 😸

Comment last updated on July 02, 2018 at 00:39 Hours UTC

@ritiek ritiek force-pushed the ritiek:cov-corners branch from 76302bc to de76681 Jun 30, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 30, 2018

Codecov Report

Merging #506 into master will increase coverage by 0.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
+ Coverage   97.58%   98.02%   +0.43%     
==========================================
  Files          44       44              
  Lines        3691     3690       -1     
==========================================
+ Hits         3602     3617      +15     
+ Misses         89       73      -16
Impacted Files Coverage Δ
plasmapy/physics/transport/collisions.py 99.53% <100%> (+0.92%) ⬆️
plasmapy/atomic/particle_class.py 100% <0%> (+0.32%) ⬆️
plasmapy/atomic/nuclear.py 100% <0%> (+1.13%) ⬆️
plasmapy/physics/parameters.py 100% <0%> (+1.18%) ⬆️
plasmapy/atomic/atomic.py 100% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b854356...26fe86b. Read the comment docs.

@StanczakDominik
Copy link
Member

StanczakDominik left a comment

Looks good! Unless you wanna add some more of DAT DELICIOUS COVERAGE I can merge straight away.

@ritiek

This comment has been minimized.

Copy link
Contributor Author

ritiek commented Jun 30, 2018

Let's wait for a bit. I think I'll also take a look at collisions.py and maybe other files.

@ritiek ritiek changed the title Add a few more tests to improve our test coverage [WIP] Add a few more tests to improve our test coverage Jun 30, 2018

@ritiek ritiek force-pushed the ritiek:cov-corners branch from 6df025e to 26fe86b Jul 2, 2018

@ritiek

This comment has been minimized.

Copy link
Contributor Author

ritiek commented Jul 2, 2018

Ok, let's merge this away for now!

@StanczakDominik StanczakDominik merged commit 158ea76 into PlasmaPy:master Jul 2, 2018

5 checks passed

ci/circleci: test-html Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.58%)
Details
codecov/project 98.02% (+0.43%) compared to b854356
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@StanczakDominik

This comment has been minimized.

Copy link
Member

StanczakDominik commented Jul 2, 2018

Done, thanks @ritiek !

@ritiek ritiek deleted the ritiek:cov-corners branch Jul 9, 2018

@namurphy namurphy added the Testing label Jul 23, 2018

@namurphy namurphy changed the title [WIP] Add a few more tests to improve our test coverage Add a few more tests to improve our test coverage Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.