Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL formatting in `online_help()` #511

Merged
merged 1 commit into from Jul 17, 2018

Conversation

Projects
None yet
4 participants
@ritiek
Copy link
Contributor

commented Jul 13, 2018

It seems like this issue went unnoticed while merging #438 (later superseded by #446). It was causing spaces to accumulate in the URL just before the query part, so it returned no search results in browser:

>>> from plasmapy import online_help
# This used to open
# http://docs.plasmapy.org/en/stable/search.html?%20%20%20%20q=particle&check_keywords=yes&area=default
# instead of actual url
# http://docs.plasmapy.org/en/stable/search.html?q=particle&check_keywords=yes&area=default
>>> online_help("particle")

This PR makes a small change to URL formatting to prevent spaces from accumulating so docs search can work properly.

@pep8speaks

This comment has been minimized.

Copy link

commented Jul 13, 2018

Hello @ritiek! Thanks for updating your pull request.

Congratulations! There are no PEP8 issues in this pull request. 😸

Comment last updated on July 13, 2018 at 16:39 Hours UTC

@ritiek ritiek force-pushed the ritiek:online-help-url branch from 5e38ebb to 2df5b94 Jul 13, 2018

@codecov

This comment has been minimized.

Copy link

commented Jul 13, 2018

Codecov Report

Merging #511 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #511   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files          44       44           
  Lines        3690     3690           
=======================================
  Hits         3617     3617           
  Misses         73       73
Impacted Files Coverage Δ
plasmapy/__init__.py 70.83% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d22b5a2...2df5b94. Read the comment docs.

@SolarDrew

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2018

👍

@SolarDrew SolarDrew merged commit 4943e25 into PlasmaPy:master Jul 17, 2018

4 of 5 checks passed

codecov/patch 0% of diff hit (target 98.02%)
Details
ci/circleci: test-html Your tests passed on CircleCI!
Details
codecov/project 98.02% remains the same compared to d22b5a2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ritiek ritiek deleted the ritiek:online-help-url branch Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.