Namedtuples for dielectric #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
==========================================
- Coverage 97.76% 97.44% -0.33%
==========================================
Files 46 46
Lines 3808 3833 +25
==========================================
+ Hits 3723 3735 +12
- Misses 85 98 +13
Continue to review full report at Codecov.
|
namurphy
requested changes
Sep 24, 2018
plasmapy/physics/dielectric.py
Outdated
| @@ -16,6 +16,8 @@ | |||
| 'cold_plasma_permittivity_LRP', | |||
| 'permittivity_1D_Maxwellian'] | |||
|
|
|||
| StixTensorElements = namedtuple("Result1", ["sum", "difference", "plasma"], ) | |||
| RotatingTensorElements = namedtuple("Result1", ["left", "right", "plasma"], ) | |||
There was a problem hiding this comment.
Would this perhaps be more descriptive?
StixTensorElements = namedtuple("StixTensorElements", ["sum", "difference", "plasma"], )
RotatingTensorElements = namedtuple("RotatingTensorElements", ["left", "right", "plasma"], )There was a problem hiding this comment.
Gah! Of course I would forget to change those.
There was a problem hiding this comment.
Addressed by 548bd59
namurphy
reviewed
Sep 28, 2018
|
Hey @namurphy, I think this could be merged now. :) |
|
Darn, I missed the comment you made about the docstrings. Apologies. Fixing those now. |
namurphy
approved these changes
Oct 12, 2018
namurphy
added
the
needs changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #539. Names can of course probably be improved.