New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] HMR not working for newtab #267
Comments
@keslert Thanks for the bug report! This is quite weird, I tested HMR with the new tab page very recently, and it worked. Could it be related to #264 ? I'm a bit busy this week, but will prioritize this and #264 once I'm free :) In my extension, I have a combination of option/newtab/popup pages and HMR worked on all of them individually. Tho, I have yet to add a component module outside of the entry files. That might be the issue :d |
@keslert can you provide the outline of your project and which file you changed to test HMR? For me, when I changed my |
I followed the instructions to create a src folder where I have a |
I tested on Brave and actually faced this issue - it seems Brave is using a newer version of chromium build than Chrome (?) - I can now see the CSP issue surfacing - will experiment with dev CSP |
Actually disregard the last msg - the HMR is sending events, however the HMR content itself was not found :d. .... @keslert do you see any error on the console regarding ERR_FILE_NOT_FOUND ? |
hmm, I'm seeing HMR not being applied if user refresh the new tab... wondering why? |
After trying to navigate directly to the HMR proxy, it seems to work consistently now... It seems there is a trick to ensure the proxy stays up - the bgsw page that's serving the proxy must stay open - this page might likely be crucial - we can also use it to pipe logs #193 as well (?)... |
It seems if user "hard-refresh" a page, the HMR broke. Likely due to killing of the service worker. |
Thankfully, we can catch the proxy error and just do a soft-refresh. Fix is on the way! |
@louisgv this is still not working for me... |
Just merged the PR and ramping up a release. Will get it out by tmr! |
What happened?
I just started using plasmo for the first time, so hopefully, I'm not just doing something wrong, but I can't get live reload to work with the newtab. I only see my changes when I refresh. I've tried with 0.56.0 and 0.57.0-alpha.2.
Version
Latest
What OS are you seeing the problem on?
MacOSX
What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
(OPTIONAL) Contact Details
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: