feat: --tag parameter #196 #282
Conversation
|
PlasmoHQ/plasmo-utils#1 |
|
@imbdb thanks for the PR! I will season this a bit and merge it this week. I think that the util common module doesn't need to be updated as it's only for the most common. Application specific flag (like the --tag) should stays locally. Great work nonetheless :) |
|
@louisgv Thanks for the comment, I have closed the utils PR. |
| @@ -35,7 +35,7 @@ export const getCommonPath = ( | |||
|
|
|||
| const distDirectoryName = `${target}-${ | |||
| process.env.NODE_ENV === "production" ? "prod" : "dev" | |||
| }` | |||
| }${tag ? '-' + tag : ''}` | |||
There was a problem hiding this comment.
I think we would replace the dev/prod entirely if a tag is present. The idea is that prod and dev are technically build tag. You can use the tag flag for both dev and prod bundle, it just influence the naming of this directory.
|
@imbdb I published this in canary, pls try it out when you got a chance :) |
|
Thanks @louisgv |
Details
Code of Conduct