Permalink
Commits on Jan 12, 2012
Commits on Oct 8, 2011
  1. Changed the way the mercurial rbtools client calculates its diff to m…

    markcatley authored and davidt committed Oct 8, 2011
    …ake it work better with merges.
    
    Consider the following diff tree:
    * - O3/tip
    |
    * - O2
    |\
    * | - U3
    | * - O1
    * | - U2
    |/
    * - U1
    |
    
    Where revisions starting with an O are outgoing revisions and those starting
    with a U are upstream revisions.
    
    The current post-review tool will post a diff of O3:U1 including revisions U2
    and U3 which are already in the repository. The following patch will change it
    to use revisions O3:U3 for the diff which will include the changesets O1-3.
    
    Testing done:
    Did post-review -n with a few different mercurial trees like the one above, as
    well as a couple of simple ones with one or two commits that have no merges.
    Then validated that the diff included all outgoing changes and the parent of the
    diff was the revision that is the most recent direct parent of our tip that is
    also in the upstream repository.
    
    Fixes bug 2311
    Reviewed at http://reviews.reviewboard.org/r/2628/
  2. Make the Mercurial tool handle the case where there are no outgoing c…

    markcatley authored and davidt committed Oct 8, 2011
    …hanges.
    
    Simple change to avoid crashing when there are no outgoing changes in a
    Mercurial repository.
    
    Testing done: Ran the tool in the case where there were outgoing changes and
    where there weren't and ensured a sensible error message was generated in the
    right cases.
    
    Reviewed at http://reviews.reviewboard.org/r/2632/
Commits on Sep 28, 2011
  1. Merge branch 'release-0.3.x'

    chipx86 committed Sep 28, 2011
  2. Compare the realm, rather than the URL, when deciding on authentication.

    chipx86 committed Sep 28, 2011
    The authentication code was falling back on the built-in Python HTTP
    Basic Auth support when the URL wasn't what we expected. This would
    break post-review in the case where the URL is old and redirects, or the
    server otherwise reports a different URL.
    
    We now compare the realm when deciding, instead of the URL. This is a
    better indicator and fixes this problem.
Commits on Sep 27, 2011
  1. Fix accidental sys.exit() call in perforce tool.

    davidt committed Sep 27, 2011
    Apparently we flubbed some indentation. Oops =(
  2. Merge branch 'release-0.3.x'

    chipx86 committed Sep 27, 2011
  3. Release RBTools 0.3.4.

    chipx86 committed Sep 27, 2011
  4. Strip newlines out of concatenated summaries.

    davidt authored and chipx86 committed Sep 27, 2011
    When posting a review using --guess-summary, we would concatenate all of
    the summary lines, including newline characters. If one then tried to
    publish the review as such, the email layer would freak out because
    there were newlines in the subject header.
    
    Fixes bug 1689
Commits on Sep 24, 2011
  1. Provide a better error message when using --revision-range on Perforc…

    mikeconley committed Sep 24, 2011
    …e repos.
    
    post-review was failing out with a confusing error message when passing
    --revision-range as an argument while using a Perforce repository.
    
    Fixes bug #1495
Commits on Sep 23, 2011
  1. Merge branch 'release-0.3.x'

    chipx86 committed Sep 23, 2011
  2. Add a --change-description option for setting the Change Description …

    Nathan Dimmock authored and chipx86 committed Sep 23, 2011
    …field.
    
    This can be used to pre-populate the change description on the command
    line without having to use the web UI.
    
    Reviewed at http://reviews.reviewboard.org/r/2594/
  3. Fix uploading diffs with non-ascii characters on Python 2.7.

    jerboaa authored and chipx86 committed Sep 23, 2011
    Python 2.7's urllib2 has some brokenness when uploading content with
    non-ascii characters. This is due to encoding differences between the
    content and the URL, and how it ends up involving both. Specifically
    passing str(url) seems to fix this.
    
    Reviewed at http://reviews.reviewboard.org/r/2568/
    Fixes bug #2155
Commits on Sep 14, 2011
  1. Merge branch 'release-0.3.x'

    chipx86 committed Sep 14, 2011
  2. Handle authentication failures when accessing /api/info/.

    chipx86 committed Sep 14, 2011
    When accessing a password-protected /api/info/ path, we wouldn't gracefully
    handle an invalid login. Instead, we would fall back on the old, deprecated
    API. This would always fail on RB 1.6, making things very confusing. Now we
    handle this better and just simply bail if we can't log in the first time.
Commits on Sep 5, 2011
  1. Strip newlines out of concatenated summaries.

    davidt committed Sep 5, 2011
    When posting a review using --guess-summary, we would concatenate all of the
    summary lines, including newline characters. If one then tried to publish the
    review as such, the email layer would freak out because there were newlines in
    the subject header.
    
    Fixes bug 1689
Commits on Aug 21, 2011
  1. Move SCMClient unit tests into clients/tests.py, and improve the test…

    mbait authored and chipx86 committed Aug 21, 2011
    … utils.
    
    All SCMClient unit tests have been moved out of rbtools/tests.py and into
    rbtools/clients/tests.py. Some of the utility functions have been moved out
    into testbase.py.
    
    Reviewed at http://reviews.reviewboard.org/r/2452/
Commits on Aug 16, 2011
  1. Bump to RBTools 0.4.0 dev.

    chipx86 committed Aug 16, 2011
  2. Merge branch 'release-0.3.x'

    chipx86 committed Aug 16, 2011
  3. Bump to RBTools 0.3.4 dev.

    chipx86 committed Aug 16, 2011
  4. Release RBTools 0.3.3.

    chipx86 committed Aug 16, 2011
  5. Modernize the release script.

    chipx86 committed Aug 16, 2011
    The release script is now on par with Review Board's. It generates sha1s of
    the released files and uploads them, and it knows how to update reviewboard.org
    with the new release information.
  6. Merge branch 'release-0.3.x'

    chipx86 committed Aug 16, 2011
  7. Accept a single revision ID for --revision-range for Mercurial.

    flowblok authored and chipx86 committed Aug 16, 2011
    Mercurial now supports --revision-range with a single revision ID now. If
    given a single revision, it will find the first parent of that revision and
    use that as the first revision of the diff.
    
    Reviewed at http://reviews.reviewboard.org/r/2546/
  8. Fix an error when posting a review inside a mercurial branch.

    dcestari authored and chipx86 committed Aug 16, 2011
    The _get_top_and_bottom_outgoing_revs method for the MercurialClient
    was assuming all revision numbers were consecutive which is not necessarily
    true at all times, especially when branches exists. This change tries to
    fetch the "parent" revision instead of just subtracting one to the bottom_rev
    to be reviewed, if this revision is not found it falls back to the old
    behavior.
    
    Reviewed at http://reviews.reviewboard.org/r/2487/
  9. Fix an error when posting a review inside a mercurial branch.

    dcestari authored and chipx86 committed Aug 16, 2011
    The _get_top_and_bottom_outgoing_revs method for the MercurialClient
    was assuming all revision numbers were consecutive which is not necessarily
    true at all times, especially when branches exists. This change tries to
    fetch the "parent" revision instead of just subtracting one to the bottom_rev
    to be reviewed, if this revision is not found it falls back to the old
    behavior.
    
    Reviewed at http://reviews.reviewboard.org/r/2487/
  10. Fix Mercurial test failure related to missing config loading.

    mbait authored and chipx86 committed Aug 16, 2011
    A Mercurial test wasn't calling load_config_files, causing a test failure.
    
    Reviewed at http://reviews.reviewboard.org/r/2547/
Commits on Aug 14, 2011
  1. Fix setting the configs variable in post-review.

    chipx86 committed Aug 14, 2011
    The config loading wasn't setting the global 'configs' variable. Now it's
    explicitly setting the global variable.
  2. Move config loading into rbtools.utils and add tests.

    mbait authored and chipx86 committed Aug 14, 2011
    The code for handling config files has been moved out of post-review
    and into rbtools.utils.filesystem where it can be used by other
    utilities.
    
    Reviewed at http://reviews.reviewboard.org/r/2519/
  3. Add tests and a test base class for rbtools.utils.

    mbait authored and chipx86 committed Aug 14, 2011
    This introduces some unit tests for the rbtools.utils module. As part
    of this, in order to ease testing, a RBTestBase class was added, which
    contains several utility functions that will help in testing the
    client and API support.
    
    Reviewed at http://reviews.reviewboard.org/r/2518/
  4. Backport change: Some cleanups in the 'api' branch.

    mbait authored and chipx86 committed Aug 14, 2011
    Many of these cleanups apply nicely to master, and will make merging
    easier later on.
    
    Original description:
    
    Some cleanups in the 'api' branch.
    
    This cleans up some of the code on the 'api' branch. It removes trailing
    whitespace, aligns parameters, fixes some PEP-8 problems, gets rid of
    some old files, fixes references to new ones, and more.
    
    Reviewed at http://reviews.reviewboard.org/r/2400/
Commits on Jul 26, 2011
  1. Pull out code of SCM clients from postreview into separate files

    mbait authored and chipx86 committed Jul 26, 2011
    This is the initial work for making RBTools an extensible set of tools with
    a Python API. The various SCMClients have been pulled out into their own
    files, as have many of the utility functions that exist in post-review used
    by the clients.
    
    The client design is much the same as it was, with their own options and
    config data associated with the client, instead of being a global part of
    post-review.
    
    This should in the future allow for third parties to provide custom clients
    without as much work, and is an important stepping stone to merging in the
    new API work.
    
    Reviewed at http://reviews.reviewboard.org/r/2399/
  2. Fix breakages in the unit tests.

    chipx86 committed Jul 26, 2011
    My change from a while back to add support for multiple configs ended
    up breaking unit tests, and due to other test infrastructure problems,
    was never caught. This boiled down to not properly resetting the config
    data, not loading in the config files after writing a .reviewboardrc file,
    and not defining a 'repository_url' default for OptionsStub. The unit tests
    now pass.