Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: On-screen keymapping hint UI #74

Open
1 task done
FlyMeToTheMoonAndLetMePlayAmongTheStars opened this issue Jan 29, 2023 · 2 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@FlyMeToTheMoonAndLetMePlayAmongTheStars
Copy link
Contributor

Is your feature request related to a problem?

I've seen many users asking in the discord why their keymapping is not working, surprisingly, they had no idea that pressing option is the key that toggles keymapping on/off. Furthermore, there are also issues related to various aspect ratios different users may have, such as 16:10 keymap on a 16:9 window. What if there was a way to solve all of this? To make the interactions more explicit? More obvious? You can't expect everyone to read the docs because the vast majority of people want an experience that 'just works' out of the box without having to read a hefty manual.

Describe the solution you'd like

I propose a visible layer UI layer that provide hints to assigned keymaps on-screen. Of course, not all keys might need the hint so perhaps in the editor there can be a checkbox where the user can choose to show or hide. And maybe even in the keymap editor the user can customize by dragging the hint 'buttons' to be relative to the actual touch position in up, down, left, and right offset positions, there are many cases where the hint would need to be offset from the actual touch location, mostly to make things look nice and prevent the hint from obscuring UI elements.

For example: when keymapping is not enabled/cursor released, there could be a hint on screen to tell the user that keymapping is currently disabled. Maybe it could show this hint once for first time users, or show every time the keymap is disabled (but might get annoying for users who are already familiar with the option key)

This is how I imagine this might look like

image

Keymapping hints for individual buttons can be toggled with a certain shortcut maybe cmd + H or something. They would show up below the keymap touch location, similar to how things are on the official PC version of Genshin Impact (though this feature can benefit many other games as well)

image

With this feature, the keymapping editor could look like this, when adding a new key a hint tag is automatically generated, and the user can click on the tag to drag it around the touch point circumference. Can also toggle to show or hide the hint by default.
image

Anything else?

This feature could work in tandem with multi-dimensional keymapping to further improve the PlayCover UX #72

Issue Language

  • Yes my issue is written in English
@FlyMeToTheMoonAndLetMePlayAmongTheStars FlyMeToTheMoonAndLetMePlayAmongTheStars changed the title [Feature]: Keymapping hint UI [Feature]: On-screen keymapping hint UI Jan 29, 2023
@Depal1 Depal1 transferred this issue from PlayCover/PlayCover Jan 29, 2023
XuYicong pushed a commit to XuYicong/PlayTools that referenced this issue Mar 4, 2023
Fixed typos in source code, and removed unused button styles
@TheMoonThatRises TheMoonThatRises self-assigned this Nov 6, 2023
@kang49
Copy link

kang49 commented May 8, 2024

Is there any update on this feature?

@XuYicong
Copy link
Member

Is there any update on this feature?

I plan to update the UI step by step. You could see the hint message is already there.

The next step I suppose would be to update the appearance of buttons, like more transparent filling with a black edge, and highlight color changed from red to cyan.

@TheMoonThatRises TheMoonThatRises removed their assignment Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

4 participants