New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up default images for Profile, Routines, and Materials #189

Closed
pkarjala opened this Issue May 4, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@pkarjala
Copy link
Contributor

pkarjala commented May 4, 2015

If a user does not upload an image, we should have one that is filler that shows up in the space where the image should be.

@pkarjala pkarjala self-assigned this May 4, 2015

@pkarjala pkarjala changed the title Set up default Profile, Routines, and Materials Set up default images for Profile, Routines, and Materials May 4, 2015

@pkarjala

This comment has been minimized.

Copy link
Contributor

pkarjala commented May 4, 2015

The best method for doing this would be to simply utilize FontAwesome icons to fill in for blank information.

Suggested icons:

Magician: http://fortawesome.github.io/Font-Awesome/icon/user/
Routine: http://fortawesome.github.io/Font-Awesome/icon/magic/
Material: http://fortawesome.github.io/Font-Awesome/icon/paperclip/ or http://fortawesome.github.io/Font-Awesome/icon/fire/

Alternatively we can use the generic http://fortawesome.github.io/Font-Awesome/icon/picture-o/ for all of them.

@davidkneely

This comment has been minimized.

Copy link
Contributor

davidkneely commented May 10, 2015

Have implemented placeholders with font-awesome. Icon does not scale with responsive layout. Should we just create images in photoshop with the font awesome icon? Then the image will be responsive and scale with the page. #189

@pkarjala

This comment has been minimized.

Copy link
Contributor

pkarjala commented May 10, 2015

Let's see how it looks with just the FA Icons and responsiveness.

@davidkneely

This comment has been minimized.

Copy link
Contributor

davidkneely commented May 10, 2015

Still having issues compiling LESS. Enabled filewatcher but getting error:
3:24:27 PM An exception occurred while executing watcher 'LESS'. Watcher has been disabled. Fix it.: Invalid executable

@pkarjala

This comment has been minimized.

Copy link
Contributor

pkarjala commented May 10, 2015

That's an issue with it not being able to find lessc on your system.

@pkarjala

This comment has been minimized.

Copy link
Contributor

pkarjala commented May 10, 2015

Taking a closer look, it looks like the <i> tags weren't properly being closed with </i>, so this is also now fixed.

Have set font-size: 400px; for placeholder image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment