Fix missing wildcard from LIKE when querying source segments for allo…

…cation.
Plumbr · Aug 1, 2018 · 7e4c709 · 7e4c709
1 parent 9b2a4f6
commit 7e4c709
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/server/src/main/java/io/druid/metadata/IndexerSQLMetadataStorageCoordinator.java b/server/src/main/java/io/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
@@ -334,6 +334,8 @@ private List<DataSegment> collectSourceSegments(
           sourceVersion.lhs.getEnd(), sourceVersion.rhs, NoneShardSpec.instance());
     }
 
+    String identifierPrefix = org.apache.commons.lang.StringUtils.getCommonPrefix(identifiers) + "%";
+
     Query<Map<String, Object>> sql = handle
         .createQuery(
             String.format(
@@ -343,7 +345,7 @@ private List<DataSegment> collectSourceSegments(
             )
         )
         .bind(0, dataSource)
-        .bind(1, org.apache.commons.lang.StringUtils.getCommonPrefix(identifiers));
+        .bind(1, identifierPrefix);
 
     index = 0;
 
@@ -352,6 +354,7 @@ private List<DataSegment> collectSourceSegments(
     }
 
     final List<DataSegment> results = new ArrayList<>();
+    int falsePositiveCount = 0;
 
     try (final ResultIterator<byte[]> dbSegments = sql
         .map(ByteArrayMapper.FIRST)
@@ -367,10 +370,16 @@ private List<DataSegment> collectSourceSegments(
 
         if (sourceVersions.contains(new Pair<>(segment.getInterval(), segment.getVersion()))) {
           results.add(segment);
+        } else {
+          falsePositiveCount++;
         }
       }
     }
 
+    log.debug("Collecting corresponding source segments for segment allocation for [%s], result is [%d] segments and " +
+        "[%d] false positives (identifier prefix [%s]).", sourceVersions, results.size(), falsePositiveCount,
+        identifierPrefix);
+
     return results;
   }