New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix menu not unfolding on iOS #549
Conversation
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
=======================================
Coverage 43.97% 43.97%
=======================================
Files 68 68
Lines 7890 7890
=======================================
Hits 3470 3470
Misses 4420 4420 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you go on https://pr-549.joinplu.me with a small screen (or by reducing the size of your browser window) you will see that the elements of the menu are always visible and overflow on the right.
I think there was a script to do that on browser that don't support :focus-within (like Safari or Chrome), but maybe it is not working? Which version of iOS are you using (if you were the one who found this bug)?
You are right. Honestly, I am not 100% sure how to adress this now, but the menu works fine in Plume Alpha 2, so the change occured between then and now. The problem is that there's no menu on iOS at all, so no access to search, login, or registration. But I'll keep experimenting further and see if I can figure something out... if not, I will close this after some time and think about it later. |
Can you see the new editor on iOS? I'm asking to be sure the WASM scripts are correctly run. |
Just tested it on the newest iOS. Yes, the editor itself works fine, it's just that the menu doesn't unfold. I think some styling with |
No description provided.