Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix menu not unfolding on iOS #549

Closed
wants to merge 6 commits into from

Conversation

marek-lach
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #549 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #549   +/-   ##
=======================================
  Coverage   43.97%   43.97%           
=======================================
  Files          68       68           
  Lines        7890     7890           
=======================================
  Hits         3470     3470           
  Misses       4420     4420

Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you go on https://pr-549.joinplu.me with a small screen (or by reducing the size of your browser window) you will see that the elements of the menu are always visible and overflow on the right.

I think there was a script to do that on browser that don't support :focus-within (like Safari or Chrome), but maybe it is not working? Which version of iOS are you using (if you were the one who found this bug)?

@marek-lach
Copy link
Member Author

marek-lach commented Apr 26, 2019

If you go on https://pr-549.joinplu.me with a small screen (or by reducing the size of your browser window) you will see that the elements of the menu are always visible and overflow on the right.

I think there was a script to do that on browser that don't support :focus-within (like Safari or Chrome), but maybe it is not working? Which version of iOS are you using (if you were the one who found this bug)?

You are right. Honestly, I am not 100% sure how to adress this now, but the menu works fine in Plume Alpha 2, so the change occured between then and now. The problem is that there's no menu on iOS at all, so no access to search, login, or registration. But I'll keep experimenting further and see if I can figure something out... if not, I will close this after some time and think about it later.

@elegaanz
Copy link
Member

Can you see the new editor on iOS? I'm asking to be sure the WASM scripts are correctly run.

@marek-lach
Copy link
Member Author

marek-lach commented Apr 26, 2019

Can you see the new editor on iOS? I'm asking to be sure the WASM scripts are correctly run.

Just tested it on the newest iOS. Yes, the editor itself works fine, it's just that the menu doesn't unfold. I think some styling with -webkit-appearence:... around the element that handles that may fix it, but am not sure exactly. On Android all is fine as always :-)

@marek-lach marek-lach closed this Apr 27, 2019
@marek-lach marek-lach deleted the fix-menu-not-unfolding-on-ios branch April 27, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants