Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #637 : Markdown footnotes #700

Merged
merged 2 commits into from Nov 20, 2019
Merged

Fix #637 : Markdown footnotes #700

merged 2 commits into from Nov 20, 2019

Conversation

papey
Copy link
Contributor

@papey papey commented Nov 20, 2019

Here is fix for issue #637 that :

  • Ensure footnotes classes are not filtered by html sanitizer
  • Add some footnote style rules

An example of footnotes using this fix :

Markdown :

Here is something[^a]


Here is another thing[^b]

[^a]: something

[^b]: another thing

Footnotes rendeering

Note that there is some cpull-markdown related syntax : a carriage return is needed between each note definition

pulldown-cmark add somes classes when footnotes html is generated. This commit ensure they are not filtered by html sanitizer
@papey
Copy link
Contributor Author

papey commented Nov 20, 2019

Note that back reference are not supported (yet) by cpull-markdown : pulldown-cmark/pulldown-cmark#142

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #700 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          72       72           
  Lines        9498     9498           
  Branches     2265     2265           
=======================================
  Hits         3728     3728           
  Misses       4713     4713           
  Partials     1057     1057

Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elegaanz elegaanz merged commit 3bd2305 into Plume-org:master Nov 20, 2019
@papey papey deleted the fix-markdown-notes branch January 13, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants