Skip to content

feat: [MC-690] Distinct Pocket dev JWK key ids #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 20, 2024
Merged

feat: [MC-690] Distinct Pocket dev JWK key ids #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8193683
feat: [MC-690] use different keys in Pocket-Dev
mmiermans Feb 14, 2024
118fa90
chore: use --elv2-license accept in start:dev
mmiermans Feb 14, 2024
6b63c6c
chore: fix lint errors in test
mmiermans Feb 14, 2024
28c96d8
wip: try to get test coverage for prod key ids
mmiermans Feb 14, 2024
ddff36a
fix: test for getSigningKeysFromServer mock env
mmiermans Feb 14, 2024
b4997e5
chore: clean up tests
mmiermans Feb 14, 2024
618ef24
fix: lint errors
mmiermans Feb 14, 2024
d91c50a
fix: try to fix errors in Github superlinter
mmiermans Feb 15, 2024
d527dc7
fix: try to upgrade superlinter eslint
mmiermans Feb 15, 2024
5b70aff
fix: Failed to get [GITHUB_TOKEN]
mmiermans Feb 15, 2024
c6816fa
fix: lint error
mmiermans Feb 15, 2024
e354950
fix attempt: secret or public key must be provided
mmiermans Feb 15, 2024
b78bfcc
fix: NODE_ENV should be development in Pocket-Dev
mmiermans Feb 15, 2024
749f6a0
fix: distinguish development (Pocket-Dev) from local dev
mmiermans Feb 15, 2024
9591e9b
chore: re-run checks
mmiermans Feb 20, 2024
ebd61aa
fix: linter error
mmiermans Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .aws/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class AdminAPI extends TerraformStack {
workspaces: {
name: 'incident-management',
},
}
},
);

return new PocketPagerDuty(this, 'pagerduty', {
Expand Down Expand Up @@ -147,7 +147,7 @@ class AdminAPI extends TerraformStack {
],
envVars: [
{
name: 'ENVIRONMENT',
Copy link
Contributor Author

@mmiermans mmiermans Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that ENVIRONMENT was not used by searching the codebase.

name: 'NODE_ENV',
value: process.env.NODE_ENV, // this gives us a nice lowercase production and development
},
{
Expand Down
21 changes: 13 additions & 8 deletions .github/workflows/linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,21 @@ jobs:
##########################
# Checkout the code base #
##########################
- name: Checkout Code
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
- name: Checkout code
uses: actions/checkout@v4
with:
# super-linter needs the full git history to get the
# list of files that changed across commits
fetch-depth: 0

##########################
# Github Super Linter needs
# the latest definitions installed
##########################
- name: Use Node.js 16.x
uses: actions/setup-node@e33196f7422957bea03ed53f6fbb155025ffc7b8 # v3.7.0
- name: Use Node.js 18.x
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: 16.x
node-version: 18.x
# Install our eslint packages.
# We may have custom tsconfigs, eslints that are brought in via a package.
- run: npm install
Expand All @@ -55,12 +59,13 @@ jobs:
# Run Linter against code base #
################################
- name: Lint Code Base

# We use the Github super linter, it can be cranky at times, so in that moment here are the docs https://github.com/github/super-linter
uses: docker://ghcr.io/github/super-linter:slim-v4@sha256:80ecaa58ad5f9480c66e3c77af5c955831861a41fb78ce7e0ffb1b443eca0f0f
uses: super-linter/super-linter@v6.0.0 # x-release-please-version

# All Environment variables are defined here https://github.com/github/super-linter#environment-variables
env:
# To report GitHub Actions status checks
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# The name of the repository default branch.
DEFAULT_BRANCH: main

Expand Down
Loading