feat(timeToRead): [DIS-852] Add time_to_read / timeToRead #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmiermans
requested review from
Herraj,
ScottDowne,
katerinachinnappan and
ml8
and removed request for
katerinachinnappan and
ml8
mmiermans
commented
Jul 26, 2023
| CH, | ||
| AT, | ||
| BE, | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
This is unrelated to time-to-read, but we just happened to notice that #55 accidentally re-introduced this enum. The generated code was not impacted by this, so requests from unsupported regions such as NL continue to work.
mmiermans
commented
Jul 26, 2023
Comment on lines
+155
to
+157
| timeToRead: | ||
| type: integer | ||
| description: Article read time in minutes |
Contributor
Author
There was a problem hiding this comment.
@ScottDowne Just to confirm, timeToRead (camel-case) is supported by Firefox when hitting the new api, right?
Seems like that's the case looking at the code: https://searchfox.org/mozilla-central/source/browser/components/pocket/content/pktApi.sys.mjs#868
Herraj
approved these changes
Jul 26, 2023
| return recommendationWithoutTimeToRead; | ||
| } | ||
| }; | ||
|
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Herraj
approved these changes
Jul 26, 2023
ScottDowne
approved these changes
Jul 26, 2023
Comment on lines
+155
to
+157
| timeToRead: | ||
| type: integer | ||
| description: Article read time in minutes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add time_to_read and timeToRead respectively to the old and new recommendation endpoint.
Implementation Decisions
References
JIRA ticket:
QA
As part of the QA steps in #908 we simulated a Parser outage, and checked that recommendations continue to be returned successfully. When firefox-api-proxy is deployed to Pocket-Dev it requests production recommendations, so we can only QA the scenario where the Parser is available for this PR.
/v3/firefox/global-recs en-GB
time_to_readis missing for a small number of the recommendations/desktop/v1/recommendations fr-FR
time_to_readis missing for a small number of the recommendations