This repository has been archived by the owner. It is now read-only.

Grass generates underwater #4159

Open
stayandwait opened this Issue Apr 30, 2016 · 9 comments

Comments

Projects
None yet
4 participants
@stayandwait

stayandwait commented Apr 30, 2016

When you create a new world, you see that grass was also generated underwater. This was a bug in MCPE but this no longer happens. It just happens in PocketMine now. (See photo attached.)

Steps to reproduce

  1. Create a new world
  2. Look for an ocean or a large lake.
  3. Observe that grass was also generated underwater.

OS and versions

  • PocketMine-MP: 0.14.0
  • PHP: 7
  • OS: Windows 10

2016-04-29_1909

@robske110

This comment has been minimized.

Show comment
Hide comment

robske110 commented Apr 30, 2016

@extremeheat

This comment has been minimized.

Show comment
Hide comment
@extremeheat

extremeheat Apr 30, 2016

Duplicate of #3173.

@robske110 that's not much of a solution rather a hack to just "make it work"...

The generator code as a whole needs to be updated.

extremeheat commented Apr 30, 2016

Duplicate of #3173.

@robske110 that's not much of a solution rather a hack to just "make it work"...

The generator code as a whole needs to be updated.

@robske110

This comment has been minimized.

Show comment
Hide comment
@robske110

robske110 Apr 30, 2016

Ok, you're right if grass is under water it shouldn't be ticked

robske110 commented Apr 30, 2016

Ok, you're right if grass is under water it shouldn't be ticked

@extremeheat

This comment has been minimized.

Show comment
Hide comment
@extremeheat

extremeheat Apr 30, 2016

@robske110 does that commit actually fix generating dirt in seas? It seems to just block dirt from growing into grass unless I'm mistaken. I'm assuming that it just so happens to fix grass under seas (since you linked that commit) but this is something that should generally be handled in the generator.

extremeheat commented Apr 30, 2016

@robske110 does that commit actually fix generating dirt in seas? It seems to just block dirt from growing into grass unless I'm mistaken. I'm assuming that it just so happens to fix grass under seas (since you linked that commit) but this is something that should generally be handled in the generator.

@robske110

This comment has been minimized.

Show comment
Hide comment
@robske110

robske110 Apr 30, 2016

Oh, I meant this issue was with growing not inital generating

robske110 commented Apr 30, 2016

Oh, I meant this issue was with growing not inital generating

@extremeheat

This comment has been minimized.

Show comment
Hide comment
@extremeheat

extremeheat commented Apr 30, 2016

Ah, I see.

@NoBakaCookies4U

This comment has been minimized.

Show comment
Hide comment
@NoBakaCookies4U

NoBakaCookies4U May 7, 2016

I don't think this is a big issue, but it does happen with me
Also, maybe this is just a minecraft issue?

NoBakaCookies4U commented May 7, 2016

I don't think this is a big issue, but it does happen with me
Also, maybe this is just a minecraft issue?

@NoBakaCookies4U

This comment has been minimized.

Show comment
Hide comment
@NoBakaCookies4U

NoBakaCookies4U May 7, 2016

It is probably because Pocketmine generates land, then puts water on top, forgetting to turn it into dirt

NoBakaCookies4U commented May 7, 2016

It is probably because Pocketmine generates land, then puts water on top, forgetting to turn it into dirt

@extremeheat

This comment has been minimized.

Show comment
Hide comment
@extremeheat

extremeheat May 7, 2016

@NoBakaCookies4U read the other messages. @robske110 already brung up the cause of issue

extremeheat commented May 7, 2016

@NoBakaCookies4U read the other messages. @robske110 already brung up the cause of issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.