Implemented hardcore banning #2574

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@LDX-MCPE
Contributor

I'm not sure if I should kick the player or not.

LDX Implemented hardcore banning
13acb5d
@sekjun9878
Member

Hmm.. interesting. If the player is dead then you should kick the player otherwise he could just respawn? Or is the respawn blocked somewhere

@PEMapModder
Collaborator

No, you should kick the player.

https://github.com/PocketMine/PocketMine-MP/blob/master/src/pocketmine/Player.php#L2024-2027

From the above link, we can see that PocketMine does not seem to detect if a player is banned when he dies.

LDX Merge pull request #1 from PEMapModder/patch-2
Added isBanned() check when RESPAWN_PACKET is received
4f1a926
@LDX-MCPE
Contributor

I wondered about that. That's why I said:

I'm not sure if I should kick the player or not.

@shoghicp shoghicp added a commit that closed this pull request Mar 17, 2015
@shoghicp shoghicp Implemented hardcore banning, closes #2574 3e893ed
@shoghicp shoghicp closed this in 3e893ed Mar 17, 2015
@LDX-MCPE LDX-MCPE deleted the unknown repository branch Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment