Fixed fallingsand bug #2770

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@MinecrafterJPN
Contributor

Fixed bug

  • A chest will break when sand fall on the chest.
@MinecrafterJPN MinecrafterJPN fixed fallingsand bug
6ff6d11
@PEMapModder
Collaborator

Maybe using (int) is better than using floor().

@Falkirks
Contributor

There is also a round method in Vector3.

@PEMapModder
Collaborator

@Falkirks

X => floor
Y => round
Z => floor

G G G
   X
G G G

G G G

Suppose bottom left corner is x.0,z.0, X would be placed outside if we use round().

For the Y, it is in case the block fell a bit more than the ground, then it would get sucked into the ground. Assuming that the block won't fall more than 0.5 block in a tick, rounding Y is more suitable.

@MinecrafterJPN MinecrafterJPN Use (int) instead of floor()
c016f9c
@MinecrafterJPN
Contributor

@PEMapModder Thank you

@shoghicp shoghicp added a commit that closed this pull request Mar 17, 2015
@shoghicp shoghicp Fixed salling sand breaking on full BB partial blocks, closes #2770 b4f62bf
@shoghicp shoghicp closed this in b4f62bf Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment