Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Block::fromString() method #4060

Open
wants to merge 1 commit into
base: master
from

Conversation

@LukeDarling
Copy link
Contributor

commented Mar 11, 2016

I believe this will work, based off of Item.php.

@PEMapModder

This comment has been minimized.

Copy link
Collaborator

commented Mar 23, 2016

I think using Item::fromString()->getBlock() is still a better approach, because names like BED should resolve into a bed block rather than null/air. Some items have $this->block set without being a BlockItem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.