This repository has been archived by the owner on Feb 9, 2021. It is now read-only.
PSR-2 violation #4260
Closed
PSR-2 violation #4260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PSR-2, it is "MUST precede" rather than "SHOULD follow"
|
maybe it was planned to violate 'em? |
|
@robske110 the contribution guidelines meant to follow the PSR-2 apart from the specified exceptions, but it comes out that this rule is not followed either, so it should be written out. Furthermore, sometimes it is followed and sometimes it is not followed, so I used SHOULD rather than MUST. |
|
This is obsoleted by changes in the PMMP repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't need to give examples where this principle is violated, do I?
https://github.com/PocketMine/PocketMine-MP/search?utf8=%E2%9C%93&q=public+abstract+function&type=Code