Validate date of birth#129
Conversation
|
@GettyOrawo Please confirm if a child born today can be added or not. |
|
@sandeshsoni yes a child born today can be added on the system |
lib/nailinda/accounts/patient.ex
Outdated
| |> validate_date_is_not_future | ||
| end | ||
|
|
||
| defp validate_date_is_not_future(changeset) do |
There was a problem hiding this comment.
Though not strict requirement, we like having private functions start with _ .
This allows us to know whether its a private function defined within the module or its been imported from other modules
In this case we can have
defp _validate_date_is_not_future(changeset) do
......
endThere was a problem hiding this comment.
I have updated the PR.
use _ prefix for private function
squashed commits to a single commit.
add prefix underscore to private function
|
This is great @sandeshsoni 😃 I love your approach towards this. Will merge it in after the other approvals. Good job! |
|
Lets wait for the conference demonstration by @LindaKadz before merging this in :-) |
|
It seems your branch does not have the latest changes from the base branch. I would request you to update your branch (pull from develop) and push so that we can merge your work. |
5 participants
Fixes issue number
fixes #127
Describe the changes made on this PR
Visuals
If your merge request had visual changes we need the screenshot of the affected pages and if behaviour changed
we will need a gif showing the new features
Screenshots
Mobile view
Attach screenshot of changes as they appear on a small screen
Desktop view
Attach screenshot of the changes as they appear on larger screens
GIF
If there were changes on how the application behaves then attach a gif showing the new changes
Reviews
I have formated by code as expected
We have a handy tool that helps you check if your elixir code is well formatted. If the tool passes on your local build
then it will definitly pass our linting checks online
I have filled in all the required information above
I have marked my work as
ready for review