Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the atto_filterws third party plugin to a brickfield_filterws plugin. #11

Open
mchurchward opened this issue Jan 9, 2020 · 3 comments
Assignees

Comments

@mchurchward
Copy link

@mchurchward mchurchward commented Jan 9, 2020

Fork the appropriate third party plugin into a new repository.
Create the MOODLE_35_STABLE branch from the direct code.
Add Travis testing.
Test the MOODLE_35_BRANCH in Travis.
Create a new BRICKFIELD_35_STABLE branch for the adapted code.
Change atto to brickfield.
Recompile the javascript code.
Test within a local Moodle install.

@mchurchward mchurchward created this issue from a note in Brickfield plugin (To do) Jan 9, 2020
@JayChurchward JayChurchward moved this from To do to In progress in Brickfield plugin Jan 13, 2020
@JayChurchward JayChurchward moved this from In progress to Review in Brickfield plugin Jan 13, 2020
@JayChurchward

This comment has been minimized.

Copy link

@JayChurchward JayChurchward commented Jan 13, 2020

Original atto plugin retrieved from https://moodle.org/plugins/atto_filterws

@mchurchward

This comment has been minimized.

Copy link
Author

@mchurchward mchurchward commented Jan 13, 2020

This one had a twist you didn't know about. In the original version.php file, there was a line that said:

$plugin->dependencies = array(
    'filter_ws'  => 2019011800,
);

This is required. What that says is that the plugin depends on another plugin's code, and there fore the other plugin needs to be installed as well. In this case, a plugin called 'filter_ws'.
You'll need to add that dependency back and retest locally.

@mchurchward mchurchward moved this from Review to To do in Brickfield plugin Jan 13, 2020
@JayChurchward JayChurchward moved this from To do to Review in Brickfield plugin Jan 13, 2020
@JayChurchward

This comment has been minimized.

Copy link

@JayChurchward JayChurchward commented Jan 13, 2020

That line has been re-added. Tags are being inserted above the textbox.
Has a dependency

@mchurchward mchurchward moved this from Review to Done in Brickfield plugin Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.