compile-time support for VTK7.1 #1770

Merged
merged 1 commit into from Jan 5, 2017

Projects

None yet

3 participants

@v4hn
Contributor
v4hn commented Dec 3, 2016

The *TupleValue function family got removed in favor of the *TypedTuple functions.

To preserve backward compatibility with older VTK versions,
this introduces local macro-overloads for the used functions.

@taketwo
Contributor
taketwo commented Dec 4, 2016

The condition for ifdefs looks mysterious. Is this some file that was added in recent versions? Why not an explicit version check?

@v4hn
Contributor
v4hn commented Dec 7, 2016 edited

Hey @taketwo,

I took the condition from the VTK Wiki examples where they are used in a couple of places.
I assume they know what they're doing.

@v4hn
Contributor
v4hn commented Dec 23, 2016

ping?

@v4hn v4hn compile-time support for VTK7.1
The *TupleValue function family got removed in favor of the *TypedTuple functions.

To preserve backward compatibility with older VTK versions,
this introduces local macro-overloads for the used functions.
7884dbd
@jspricke jspricke merged commit ad67293 into PointCloudLibrary:master Jan 5, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment