Missing sprites

[devmike123]

No description provided.

[devmike123]

@Naramsim pr ready for merge

[Naramsim]

Thanks!

[joseph-bayer]

Hey @devmike123 and @Naramsim!

This pr provided a huge amount of missing art - when do the changes get reflected on the API?

I'm asking because I'm not sure if it's an automatic process to update the API or something that needs to be done manually. If it has to be done manually, I'd love to help!

Thanks,

-Joe

[devmike123]

Hey @devmike123 and @Naramsim!

This pr provided a huge amount of missing art - when do the changes get reflected on the API?

I'm asking because I'm not sure if it's an automatic process to update the API or something that needs to be done manually. If it has to be done manually, I'd love to help!

Thanks,

-Joe

It's automatic.

[joseph-bayer]

@devmike123 - cool! Does a pipeline need to be ran? I don’t see these images when calling the current API. For example, the payload for Eternal Floette doesn’t have the official art url populated: https://pokeapi.co/api/v2/pokemon/floette-eternal

[C-Garza]

The sprites repo lives as a submodule in pokeapi here https://github.com/PokeAPI/pokeapi/tree/master/data/v2. The commit it's pointing to probably has to be updated.

[joseph-bayer]

The sprites repo lives as a submodule in pokeapi here https://github.com/PokeAPI/pokeapi/tree/master/data/v2. The commit it's pointing to probably has to be updated.

Ah that makes sense! If the timing is right to update that, I can create a pull request pointing to the newest commit in the sprites repo (preferably after this pull request is merged).

[devmike123]

The sprites repo lives as a submodule in pokeapi here https://github.com/PokeAPI/pokeapi/tree/master/data/v2. The commit it's pointing to probably has to be updated.

Ah that makes sense! If the timing is right to update that, I can create a pull request pointing to the newest commit in the sprites repo (preferably after this pull request is merged).

With pleasure