Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to handle both linting and formatting with Prettier #865

Closed
avelynhc opened this issue Nov 22, 2023 · 5 comments
Closed

Add a command to handle both linting and formatting with Prettier #865

avelynhc opened this issue Nov 22, 2023 · 5 comments

Comments

@avelynhc
Copy link
Contributor

When running npm run lint, it prompts me to execute Prettier separately for formatting. It would be convenient if npm run lint could handle both linting and formatting without the need for an additional Prettier command.

Screenshot 2023-11-22 at 6 11 27 PM
@avelynhc avelynhc changed the title Add a prettier script Add a command to handle both linting and formatting with Prettier Nov 22, 2023
@anth-volk
Copy link
Collaborator

Perhaps as part of this or separately, it's probably best to change the make format rule to not use Black, as that seems non-standard

@avelynhc
Copy link
Contributor Author

avelynhc commented Nov 23, 2023

@anth-volk Can I work on this issue first, and then tackle the next one?

@anth-volk
Copy link
Collaborator

anth-volk commented Nov 23, 2023 via email

@MaxGhenis
Copy link
Contributor

Removing black here sounds fine since there's not much Python, but just as context we use it in all the PolicyEngine Python packages (and I do like how directive it is)

@anth-volk
Copy link
Collaborator

Completed via #902. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants