Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsigned Thea Extrinsic #669

Merged
merged 8 commits into from
Apr 5, 2023
Merged

Unsigned Thea Extrinsic #669

merged 8 commits into from
Apr 5, 2023

Conversation

nakul1010
Copy link
Contributor

Closes #668.

@nakul1010 nakul1010 added the A3-InProgress Pull request is in progress. No review needed at this stage. label Mar 20, 2023
@nakul1010 nakul1010 self-assigned this Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -1.49 ⚠️

Comparison is base (81bb982) 45.16% compared to head (7a94711) 43.67%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           Develop     #669      +/-   ##
===========================================
- Coverage    45.16%   43.67%   -1.49%     
===========================================
  Files           35       35              
  Lines         2739     2832      +93     
===========================================
  Hits          1237     1237              
- Misses        1502     1595      +93
Impacted Files Coverage Δ
pallets/thea/src/lib.rs 0.00% <0.00%> (ø)
runtime/src/lib.rs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nakul1010 nakul1010 added A0-PleaseReview Pull request needs code review. and removed A3-InProgress Pull request is in progress. No review needed at this stage. labels Mar 20, 2023
serhii-temchenko
serhii-temchenko requested changes Mar 21, 2023
View reviewed changes
pallets/thea/src/lib.rs Outdated Show resolved Hide resolved
pallets/thea/src/lib.rs Outdated Show resolved Hide resolved
pallets/thea/src/lib.rs Show resolved Hide resolved
pallets/thea/src/lib.rs Outdated Show resolved Hide resolved
pallets/thea/src/lib.rs Show resolved Hide resolved
pallets/thea/src/lib.rs Show resolved Hide resolved
pallets/thea/src/lib.rs Outdated Show resolved Hide resolved
@nakul1010 nakul1010 added A3-InProgress Pull request is in progress. No review needed at this stage. and removed A0-PleaseReview Pull request needs code review. labels Mar 21, 2023
@nakul1010 nakul1010 added A0-PleaseReview Pull request needs code review. and removed A3-InProgress Pull request is in progress. No review needed at this stage. labels Mar 21, 2023
@nakul1010 nakul1010 linked an issue Mar 21, 2023 that may be closed by this pull request
make thea Extrinsics Unsigned & Feeless #668
Closed
3 tasks
@nakul1010
Copy link
Contributor Author

End to End Test failing

@Gauthamastro Gauthamastro merged commit 65f9889 into Develop Apr 5, 2023
@Gauthamastro Gauthamastro deleted the npa-thea-unsigned-ext branch April 5, 2023 13:06
@nakul1010 nakul1010 mentioned this pull request Apr 5, 2023
Merged
nakul1010 added a commit that referenced this pull request Apr 6, 2023
@nakul1010
Revert "Unsigned Thea Extrinsic" (#695)
5f34ea5 
Reverts #669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauthamastro Gauthamastro Gauthamastro approved these changes

@serhii-temchenko serhii-temchenko serhii-temchenko approved these changes

@felixfaisal felixfaisal Awaiting requested review from felixfaisal

Assignees

@nakul1010 nakul1010

Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make thea Extrinsics Unsigned & Feeless
3 participants
@nakul1010 @Gauthamastro @serhii-temchenko