Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method to convert missing values from files #104

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@AtharvaKhare
Copy link
Contributor

commented Jun 19, 2019

The method replaces missing values in input file with nil.

Additional tests with the fix for #65

Added method to convert missing values from files
The method replaces missing values in input file with nil
@AtharvaKhare AtharvaKhare referenced this pull request Jun 20, 2019
@olekscode

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

DataFrame class >> readFrom: using: missingValuesString: is not tested

@AtharvaKhare

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

@olekscode I was planning on adding tests to it with the issue #65 and #97.

Do you want me to add them now?

@olekscode

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

Yes, it's important that all code that you submit is well tested.
Issue #65 is there because I didn't have time to test everything in the past
But that's a bad thing to do

@AtharvaKhare

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2019

I have written a new test, but it fails due to incompatiblity of DataFrameTypeDetector with nil. I have created a PR to fix that #107

After the PR is merged, I will push the test.

@olekscode olekscode merged commit 75823b5 into PolyMathOrg:master Jul 11, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 90.396%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.