Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method to convert missing values from files #104

Merged
merged 1 commit into from Jul 11, 2019

Conversation

AtharvaKhare
Copy link
Contributor

The method replaces missing values in input file with nil.

Additional tests with the fix for #65

The method replaces missing values in input file with nil
@olekscode
Copy link
Member

DataFrame class >> readFrom: using: missingValuesString: is not tested

@AtharvaKhare
Copy link
Contributor Author

@olekscode I was planning on adding tests to it with the issue #65 and #97.

Do you want me to add them now?

@olekscode
Copy link
Member

olekscode commented Jun 21, 2019

Yes, it's important that all code that you submit is well tested.
Issue #65 is there because I didn't have time to test everything in the past
But that's a bad thing to do

@AtharvaKhare
Copy link
Contributor Author

I have written a new test, but it fails due to incompatiblity of DataFrameTypeDetector with nil. I have created a PR to fix that #107

After the PR is merged, I will push the test.

@olekscode olekscode merged commit 75823b5 into PolyMathOrg:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants