Added method to convert missing values from files#104
Merged
olekscode merged 1 commit intoPolyMathOrg:masterfrom Jul 11, 2019
Merged
Added method to convert missing values from files#104olekscode merged 1 commit intoPolyMathOrg:masterfrom
olekscode merged 1 commit intoPolyMathOrg:masterfrom
Conversation
The method replaces missing values in input file with nil
Closed
Member
|
|
Contributor
Author
|
@olekscode I was planning on adding tests to it with the issue #65 and #97. Do you want me to add them now? |
Member
|
Yes, it's important that all code that you submit is well tested. |
Contributor
Author
|
I have written a new test, but it fails due to incompatiblity of DataFrameTypeDetector with nil. I have created a PR to fix that #107 After the PR is merged, I will push the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method replaces missing values in input file with nil.
Additional tests with the fix for #65