Joins between dataframes and nil init of dataseries #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate column names are renamed to `_x` and `_y` respectively.
Also dded a private method to get output columns of a join operation.
Also added a `findAll: atColumn` and `findAllIndicesOf: atColumn` method to gather rows with specific object at given column. Note: The join operation does not sort keys.
`#() asDataSeries` used to fail. Added relevant tests.
Contributor
Author
|
@olekscode Please review. Using individual commits to review will be much easier :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58.
innerJoin,outerJoin,leftJoin,rightJoinare joins based onrowNamesonly. Since row names are unique, resulting code is bit simpler (and faster).Other joins are with arbitary columns. It is possible to combine both of them, but it will make the code much more complex.
There are multiple tests added to handle edge cases. Some tests may seem repetitive, because of output of joins, but they are kept to highlight differences between different methods.
#() asDataSerieswas not working - 9857c5c fixes it.