Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added methods to fill nils with Mean, Mode, Median #111

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@AtharvaKhare
Copy link
Contributor

@AtharvaKhare AtharvaKhare commented Jul 15, 2019

Final (hopefully) PR for missing data issues.

Copy link

@khinsen khinsen left a comment

I find the term "filling" surprising. Is this used anywhere else? I'd say you are replacing nils, not filling them as one might fill an empty bucket.

Loading

@AtharvaKhare
Copy link
Contributor Author

@AtharvaKhare AtharvaKhare commented Jul 17, 2019

@khinsen Since nils are missing values, I was thinking of "filling missing values" => fillNils. But replacing seems to be better naming. I will change it. :)

Edit: Pandas uses fillna parameter

Loading

@olekscode olekscode merged commit 6108564 into PolyMathOrg:master Aug 2, 2019
3 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants