Added methods to fill nils with Mean, Mode, Median #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khinsen
reviewed
Jul 16, 2019
khinsen
left a comment
khinsen
left a comment
There was a problem hiding this comment.
I find the term "filling" surprising. Is this used anywhere else? I'd say you are replacing nils, not filling them as one might fill an empty bucket.
Contributor
Author
|
@khinsen Since nils are missing values, I was thinking of "filling missing values" => fillNils. But replacing seems to be better naming. I will change it. :) Edit: Pandas uses |
AtharvaKhare
force-pushed
the
fillNilsNew
branch
from
3a90df3 to
3bed6c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final (hopefully) PR for missing data issues.