Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added methods to fill nils with Mean, Mode, Median #111

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@AtharvaKhare
Copy link
Contributor

commented Jul 15, 2019

Final (hopefully) PR for missing data issues.

@khinsen
Copy link

left a comment

I find the term "filling" surprising. Is this used anywhere else? I'd say you are replacing nils, not filling them as one might fill an empty bucket.

@AtharvaKhare

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

@khinsen Since nils are missing values, I was thinking of "filling missing values" => fillNils. But replacing seems to be better naming. I will change it. :)

Edit: Pandas uses fillna parameter

@AtharvaKhare AtharvaKhare force-pushed the AtharvaKhare:fillNilsNew branch from 3a90df3 to 3bed6c8 Jul 17, 2019

@olekscode olekscode merged commit 6108564 into PolyMathOrg:master Aug 2, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 90.649%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.