From 52efca3865d674f9e35a74f5db1e7c07b528427d Mon Sep 17 00:00:00 2001 From: CyrilFerlicot Date: Fri, 7 Apr 2023 17:20:40 +0200 Subject: [PATCH 1/2] Do not add #defaultNormalizer when we already have #defaultNormalizerClass --- src/DataFrame/DataFrame.class.st | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/DataFrame/DataFrame.class.st b/src/DataFrame/DataFrame.class.st index 472aa09a..efcde45e 100644 --- a/src/DataFrame/DataFrame.class.st +++ b/src/DataFrame/DataFrame.class.st @@ -159,12 +159,6 @@ Class { #category : #'DataFrame-Core' } -{ #category : #defaults } -DataFrame class >> defaultNormalizer [ - - ^ AIMinMaxNormalizer -] - { #category : #'instance creation' } DataFrame class >> new: aPoint [ @@ -1366,7 +1360,7 @@ DataFrame >> normalized [ "This methods returns a new DataFrame, without altering this one, that has all the columns normalized." | normalizers normalizedColumns | - normalizers := (1 to: self anyOne size) collect: [ :e | self class defaultNormalizer new ]. + normalizers := (1 to: self anyOne size) collect: [ :e | self class defaultNormalizerClass new ]. normalizedColumns := self columns with: normalizers From 8116241d77af7f75cc8ac1065c3bf19ce72c7709 Mon Sep 17 00:00:00 2001 From: CyrilFerlicot Date: Fri, 7 Apr 2023 17:28:01 +0200 Subject: [PATCH 2/2] Deprecate #normalized --- src/DataFrame/DataFrame.class.st | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/DataFrame/DataFrame.class.st b/src/DataFrame/DataFrame.class.st index efcde45e..613b3904 100644 --- a/src/DataFrame/DataFrame.class.st +++ b/src/DataFrame/DataFrame.class.st @@ -1360,11 +1360,11 @@ DataFrame >> normalized [ "This methods returns a new DataFrame, without altering this one, that has all the columns normalized." | normalizers normalizedColumns | - normalizers := (1 to: self anyOne size) collect: [ :e | self class defaultNormalizerClass new ]. + self deprecated: + 'DataFrame will remove the dependency over normalization in the next version. You can use pharo-ai/data-preprocessing project to normalize your DataFrame and even more!'. + normalizers := (1 to: self anyOne size) collect: [ :e | self class defaultNormalizerClass new ]. - normalizedColumns := self columns - with: normalizers - collect: [ :col :normalizer | col normalizedUsing: normalizer ]. + normalizedColumns := self columns with: normalizers collect: [ :col :normalizer | col normalizedUsing: normalizer ]. ^ self class withColumns: normalizedColumns columnNames: self columnNames ]