From f38ba1746a01aa6f6963d0d73b1c8ea5e692731e Mon Sep 17 00:00:00 2001 From: Shannon Clarke Date: Fri, 21 Sep 2018 09:40:34 -0400 Subject: [PATCH 1/2] fix(issuer): display dummy page for incompatible browsers display dummy page for incompatible browsers --- packages/polymath-issuer/src/RouteLoader.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/polymath-issuer/src/RouteLoader.js b/packages/polymath-issuer/src/RouteLoader.js index 9c1c72a01..b50be91ac 100644 --- a/packages/polymath-issuer/src/RouteLoader.js +++ b/packages/polymath-issuer/src/RouteLoader.js @@ -9,7 +9,7 @@ import PolymathAuth, { NETWORK_KOVAN, } from '@polymathnetwork/auth'; import { MetamaskPage, DummyPage } from '@polymathnetwork/ui'; -import { isMobile } from 'react-device-detect'; +import { isMobile, isChrome, isFirefox, isOpera } from 'react-device-detect'; import Root from './app/Root'; import SplashPage from './app/SplashPage'; @@ -24,7 +24,7 @@ type Props = { class RouteLoader extends Component { render() { - if (isMobile) { + if (isMobile || (!isChrome && !isFirefox && !isOpera)) { return ( From fb328a4598ce7679f6904f2fe7bbfef56241b63e Mon Sep 17 00:00:00 2001 From: Shannon Clarke Date: Fri, 21 Sep 2018 09:50:50 -0400 Subject: [PATCH 2/2] fix(issuer): improve readability add constant for readability improvements --- packages/polymath-issuer/src/RouteLoader.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/polymath-issuer/src/RouteLoader.js b/packages/polymath-issuer/src/RouteLoader.js index b50be91ac..8757b78be 100644 --- a/packages/polymath-issuer/src/RouteLoader.js +++ b/packages/polymath-issuer/src/RouteLoader.js @@ -24,7 +24,8 @@ type Props = { class RouteLoader extends Component { render() { - if (isMobile || (!isChrome && !isFirefox && !isOpera)) { + const isUnsupportedBrowser = !isChrome && !isFirefox && !isOpera + if (isMobile || isUnsupportedBrowser) { return (